Skip to content

Make LitModels a compatibility wrapper around LitLogger - #145

Open
justusschock wants to merge 8 commits into
mainfrom
experiment_integration
Open

Make LitModels a compatibility wrapper around LitLogger#145
justusschock wants to merge 8 commits into
mainfrom
experiment_integration

Conversation

@justusschock

@justusschock justusschock commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Turns LitModels model I/O into a compatibility facade over litlogger.models.

  • re-exports upload, download, save, load, cloud, and serialization helpers from LitLogger
  • removes duplicate LitModels implementations and the private teamspace-listing surface
  • depends on litlogger>=2026.8.28 and its minimum lightning-sdk>=2026.8.5
  • requires Python 3.11+, matching the latest LitLogger release
  • preserves the public LitModels import paths
  • verifies that compatibility exports are the same objects as the LitLogger implementations
  • moves dependencies from requirements.txt into pyproject.toml
  • derives package versions from Git tags with setuptools-scm

Testing

  • Python 3.11 minimum-dependency non-cloud suite
  • compatibility exports and checkpoint callbacks
  • Ruff formatting and linting
  • mypy
  • clean-tree wheel and source distribution build with twine check
  • cloud integration matrix across Linux, macOS, and Windows

@justusschock justusschock changed the title update Track Experiment creating models Mar 31, 2026
@justusschock justusschock changed the title Track Experiment creating models Make LitModels a compatibility wrapper around LitLogger Sep 25, 2026
@codecov-commenter

codecov-commenter commented Sep 25, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86%. Comparing base (d3e3247) to head (bf38d2e).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@         Coverage Diff          @@
##           main   #145    +/-   ##
====================================
+ Coverage    84%    86%    +2%     
====================================
  Files        12     12            
  Lines       511    384   -127     
====================================
- Hits        430    330   -100     
+ Misses       81     54    -27
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

deependujha
deependujha reviewed Sep 25, 2026
View reviewed changes
Comment thread src/litmodels/io/utils.py

@deependujha deependujha Sep 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this file then? Shouldn't we just drop it?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner
@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner
1 more reviewer
@deependujha deependujha deependujha approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justusschock @codecov-commenter @deependujha